Skip to content

GH-1357: parse Flight SQL JDBC boolean properties case-insensitively - #1358

Open
Arawoof06 wants to merge 1 commit into
apache:mainfrom
Arawoof06:jdbc-boolean-property-case-insensitive
Open

Arawoof06 wants to merge 1 commit into
apache:mainfrom
Arawoof06:jdbc-boolean-property-case-insensitive

Conversation

@Arawoof06

Copy link
Copy Markdown
Contributor

What's Changed

ArrowFlightConnectionProperty.getBoolean only treated 1 and the exact lowercase true as true, and connection-string values are not normalized, so useEncryption=TRUE (or True) parsed as false. Since useEncryption defaults to true and drives withEncryption, that silently downgraded the connection to plaintext and sent the auth handshake and credentials in the clear. This compares true case-insensitively while still honoring 1, matching how JDBC drivers normally parse boolean options.

Closes #1357.

@github-actions

Copy link
Copy Markdown

Thank you for opening a pull request!

Please label the PR with one or more of:

  • bug-fix
  • chore
  • dependencies
  • documentation
  • enhancement

Also, add the 'breaking-change' label if appropriate.

See CONTRIBUTING.md for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flight SQL JDBC parses boolean properties case-sensitively, silently disabling TLS for useEncryption=TRUE

1 participant