Skip to content

GH-37993: [CI] Fix conda-integration build#37990

Merged
raulcd merged 1 commit intoapache:mainfrom
pitrou:conda-integration-311
Oct 3, 2023
Merged

GH-37993: [CI] Fix conda-integration build#37990
raulcd merged 1 commit intoapache:mainfrom
pitrou:conda-integration-311

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Oct 3, 2023 •
edited by github-actions bot
Loading

Rationale for this change

The conda-integration build has recently started failing:
https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453

Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet does not support it yet.

What changes are included in this PR?

Avoid using Python 3.12 for Archery in conda-integration build.

Are these changes tested?

Yes, by construction.

Are there any user-facing changes?

No.

@pitrou pitrou mentioned this pull request Oct 3, 2023
Merged
@github-actions github-actions bot added the awaiting review Awaiting review label Oct 3, 2023
@pitrou pitrou force-pushed the conda-integration-311 branch from 2271a36 to 46e2aa5 Compare October 3, 2023 13:31
@pitrou pitrou marked this pull request as ready for review October 3, 2023 14:08
@pitrou pitrou removed request for assignUser and kou October 3, 2023 14:08
@pitrou pitrou changed the title [CI] Fix conda-integration build GH-37993: [CI] Fix conda-integration build Oct 3, 2023
@apache apache deleted a comment from github-actions bot Oct 3, 2023
@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Oct 3, 2023

Integration build was successful: https://github.com/apache/arrow/actions/runs/6393710784/job/17353516711?pr=37990

@pitrou pitrou requested a review from kou October 3, 2023 14:26
raulcd
raulcd approved these changes Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pitrou
CI failures were unrelated I am re-running them but will merge once they finish.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 3, 2023
@raulcd raulcd merged commit f6afc33 into apache:main Oct 3, 2023
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 3, 2023
@pitrou pitrou deleted the conda-integration-311 branch October 3, 2023 15:34
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow bot commented Oct 3, 2023

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit f6afc33.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

@tustvold tustvold mentioned this pull request Oct 4, 2023
Merged
@tustvold
Copy link
Copy Markdown
Contributor

tustvold commented Oct 4, 2023

We are still seeing failures in arrow-rs - https://github.com/apache/arrow-rs/actions/runs/6405057279/job/17386849288

It appears to be using https://hub.docker.com/layers/apache/arrow-dev/amd64-conda-integration/images/sha256-8ed7ddbadbd9a6d32d66ab8896b7f05db34a42e34ba1f5d0ba4df2113dce6ce5?context=explore which was published after this was merged, so I would have expected it to contain this fix?

Any ideas?

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Oct 4, 2023

@tustvold Apparently you are calling pip install -e dev/archery. You instead need pip install -e dev/archery[integration].

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Oct 4, 2023

Ah, and you must call pip install pythonnet explicitly as well.

@tustvold tustvold mentioned this pull request Oct 4, 2023
Merged
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@pitrou @loicalleyne
apacheGH-37993: [CI] Fix conda-integration build (apache#37990)
50b785c 
### Rationale for this change

The conda-integration build has recently started failing:
https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453

Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249).

### What changes are included in this PR?

Avoid using Python 3.12 for Archery in conda-integration build.

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.
* Closes: apache#37993

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@pitrou @dgreiss
apacheGH-37993: [CI] Fix conda-integration build (apache#37990)
8091434 
### Rationale for this change

The conda-integration build has recently started failing:
https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453

Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet [does not support it yet](pythonnet/pythonnet#2249).

### What changes are included in this PR?

Avoid using Python 3.12 for Archery in conda-integration build.

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.
* Closes: apache#37993

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulcd raulcd raulcd approved these changes

@kou kou Awaiting requested review from kou kou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI][Integration] conda-integration build failures

3 participants

@pitrou @tustvold @raulcd