[v3-2-test] Backport 65628#67013
Open
bbovenzi wants to merge 2 commits into
Open
Conversation
Remove the two mocked only_new dry-run tests that patched SerializedDAG.clear and asserted it was called — the dry-run path no longer calls dag.clear() for only_new=True (it queries the DB directly for TI existence instead). Replace with a real DB-backed test: since DAG1_RUN1_ID already has TIs for all tasks in the latest DAG version, the endpoint correctly returns 0 new tasks. Also fix test_only_new_skips_task_that_already_has_ti to create the task_b TI via the non-dry-run API endpoint instead of constructing a bare TaskInstance object, which requires a task Operator and dag_version_id and would fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually backport #65628
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.