Skip to content

Hide legacy sql connection#64923

Merged
jscheffl merged 1 commit intoapache:mainfrom
jscheffl:bugfix/hide-legacy-sql-connection
Apr 9, 2026
Merged

Hide legacy sql connection#64923
jscheffl merged 1 commit intoapache:mainfrom
jscheffl:bugfix/hide-legacy-sql-connection

Conversation

@jscheffl
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl commented Apr 8, 2026

I noticed while testing 3.2.0 with helm chart <=1.19.0 that the auto-templates env AIRFLOW__CORE__SQL_ALCHEMY_CONN is not masked. This is not happening in Chart 1.20++ but if you have not upgraded and Airflow 3.0.0 is used with expose_config: non-sensitive-only (or True) then the db credentials from the legacy key are not masked/visible.

This PR adds it to the list of sensitive values.. with the trade-off that implicitly the legacy options gets supported. If wanted I can alternatively implement a more complex option as well which adds another masking list for non-supported legacy values.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffl jscheffl requested a review from ashb as a code owner April 8, 2026 20:39
@jscheffl jscheffl added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 8, 2026
@jscheffl jscheffl merged commit 645413b into apache:main Apr 9, 2026
65 checks passed
@github-actions github-actions Bot added this to the Airflow 3.2.1 milestone Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.1 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
❌ v3-2-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 645413b v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

jscheffl added a commit to jscheffl/airflow that referenced this pull request Apr 9, 2026
@jscheffl
[v3-2-test] Hide legacy sql connection (apache#64923)
65cef3e 
(cherry picked from commit 645413b)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl added a commit that referenced this pull request Apr 9, 2026
@jscheffl
[v3-2-test] Hide legacy sql connection (#64923) (#64973)
6d6be2e 
(cherry picked from commit 645413b)
@jscheffl jscheffl mentioned this pull request Apr 9, 2026
Merged
1 task
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
@jscheffl @vatsrahul1001
[v3-2-test] Hide legacy sql connection (#64923) (#64973)
03ebefc 
(cherry picked from commit 645413b)
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
@jscheffl @vatsrahul1001
[v3-2-test] Hide legacy sql connection (#64923) (#64973)
60de6f5 
(cherry picked from commit 645413b)
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
@jscheffl @vatsrahul1001
[v3-2-test] Hide legacy sql connection (#64923) (#64973)
60a0892 
(cherry picked from commit 645413b)
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
@jscheffl @vatsrahul1001
[v3-2-test] Hide legacy sql connection (#64923) (#64973)
05f67da 
(cherry picked from commit 645413b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

Assignees

No one assigned

Labels

backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Milestone

Airflow 3.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jscheffl @potiuk @bugraoz93