Skip to content

Fix read out of order issue with send method in CommsDecoder#64894

Merged
dabla merged 3 commits intoapache:mainfrom
dabla:fix/comms-send-read-out-of-order
Apr 9, 2026
Merged

Fix read out of order issue with send method in CommsDecoder#64894
dabla merged 3 commits intoapache:mainfrom
dabla:fix/comms-send-read-out-of-order

Conversation

@dabla
Copy link
Copy Markdown
Contributor

@dabla dabla commented Apr 8, 2026

This PR fixes a possible read out of order issue with send method in CommsDecoder mentioned by @uranusjr due to the fact that the call to _get_response method wasn't inside the thread_lock due to indentation error.

Added unit test to protect us from such regression in the future.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@dabla dabla added the affected_version:3.2 Use for reporting issues with 3.2 label Apr 8, 2026
@dabla dabla requested review from amoghrajesh, ashb and kaxil as code owners April 8, 2026 09:52
@dabla dabla self-assigned this Apr 8, 2026
@dabla dabla added backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch area:task-sdk and removed area:task-sdk labels Apr 8, 2026
@uranusjr
Copy link
Copy Markdown
Member

uranusjr commented Apr 8, 2026

I think you accidentally removed a bunch of shared libs

@dabla dabla force-pushed the fix/comms-send-read-out-of-order branch from 4918d24 to 4f611df Compare April 8, 2026 10:55
@dabla dabla force-pushed the fix/comms-send-read-out-of-order branch from 4f611df to 5fc6ef7 Compare April 8, 2026 10:57
@dabla
Copy link
Copy Markdown
Contributor Author

dabla commented Apr 8, 2026

I think you accidentally removed a bunch of shared libs

Yes fixed it

@dabla dabla merged commit 3ac0d74 into apache:main Apr 9, 2026
112 checks passed
@github-actions github-actions Bot added this to the Airflow 3.2.1 milestone Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.1 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions Bot pushed a commit that referenced this pull request Apr 9, 2026
…der (#64894)

* refactor: Fix read out-of-order issue with send method in CommsDecoder
(cherry picked from commit 3ac0d74)

Co-authored-by: David Blain <info@dabla.be>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

dabla added a commit that referenced this pull request Apr 10, 2026
…der (#64894) (#64946)

* refactor: Fix read out-of-order issue with send method in CommsDecoder
(cherry picked from commit 3ac0d74)

Co-authored-by: David Blain <info@dabla.be>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…der (#64894) (#64946)

* refactor: Fix read out-of-order issue with send method in CommsDecoder
(cherry picked from commit 3ac0d74)

Co-authored-by: David Blain <info@dabla.be>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…der (#64894) (#64946)

* refactor: Fix read out-of-order issue with send method in CommsDecoder
(cherry picked from commit 3ac0d74)

Co-authored-by: David Blain <info@dabla.be>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…der (#64894) (#64946)

* refactor: Fix read out-of-order issue with send method in CommsDecoder
(cherry picked from commit 3ac0d74)

Co-authored-by: David Blain <info@dabla.be>
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…der (#64894) (#64946)

* refactor: Fix read out-of-order issue with send method in CommsDecoder
(cherry picked from commit 3ac0d74)

Co-authored-by: David Blain <info@dabla.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affected_version:3.2 Use for reporting issues with 3.2 area:task-sdk backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants