Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Works as described, and I have no concerns. I ran /export → save to file with new-designs on, from source on the base and on this branch. The "Session exported" dialog goes from one blank row above the footer band to two, and the export options dialog is unchanged (screenshots of the export result dialog below). With the experiment off, or for a dialog without a footer, the extra padding is 0, so those stay as they were. I checked that from the code rather than by running it. dialog-prompt.test.tsx and the packages/tui typecheck pass.
Public API: unchanged. footerGap is a new optional prop on the internal DialogLayout component.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple dialogs (prompts and the export result) get two blank rows above the footer band, matching the new dialog designs. List dialogs keep one row.
DialogLayoutgains an optionalfooterGap(default 1), applied only under thenew-designsexperiment.DialogPromptandDialogExportResultpassfooterGap={2}.With the experiment off, nothing changes.
First PR in a stack of TUI new-design changes.