Repository navigation
Conversation
This was referenced Oct 16, 2026
neriousy
added this pull request to stack #56077
October 16, 2026 13:20
neriousy
force-pushed
the
desktop-release-files
branch
from
October 16, 2026 16:08
fb05627 to
5d5aa4f
Compare
Each build-electron leg uploaded all of packages/desktop/dist, including the unpacked app folders and builder debug files, at deflate level 6. publish only ships the top-level installers that packages/desktop/scripts/publish.ts globs, so upload just those, uncompressed, and fail if a leg produced none.
neriousy
force-pushed
the
desktop-release-files
branch
from
October 16, 2026 16:21
5d5aa4f to
dcdfc31
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #56070 (
cli-target-jobs) ("chore(ci): build each CLI target in its own job and sign macOS and Windows in parallel"), which is stacked on #55987 (release-runner-moves). Only the last commit belongs to this PR.Summary
Each
build-electronleg uploads all ofpackages/desktop/dist/*(unpacked app and builder debug files included) at deflate level 6: 769 files, ~1.3 GB and 64–105 s on macOS.publishuses only the top-level installers matched bypackages/desktop/scripts/publish.ts's glob, plus the two Windows.exefor WinGet.This PR changes only that upload step:
path: one pattern per extension in that glob (@actions/globcan't expand braces), with a comment pointing atpublish.ts.compression-level: 0: the installers are already compressed.if-no-files-found: error: a leg matching nothing fails at upload, not inpublish.The
latest-yml-<target>upload is unchanged.Expected effect
All numbers are estimates from dev releases 38536124977 (2.0.29) and 38785024495 (2.0.30).
publishdownloads 3.42 GB in 20 files instead of 5.66 GB in ~1,916 files (today 29.0 s and 75.6 s; est. ~18 s and ~45 s).publish. Off the critical path: ~2–2.5 runner-minutes and ~2.2 GB less artifact storage per release.build-electronand gain nothing.Evidence
opencode-desktop-*files; each matches a new pattern and each pattern matches one.disttrees picked exactly 5/2/3 files with rootpackages/desktop/dist, and failed with "No files were found" when no installer existed.publish.ts's glob returns the same list for old and new inputs.publishdownloads these artifacts..tar.gzcame back byte-identical. Only an entry starting withPK\x07\x08fails; no shipped format does.Things to know
publish.ts. New risk: a change to its glob (or beta'supload.tsglob) must update this list, or that format silently stops shipping.if-no-files-found: erroronly catches a leg with no matches. A single missing extension is caught as today:publish.tsthrows for files listed inlatest*.yml(12 of 20). The other 8 (.app.tar.gzand blockmaps) are unchecked, before and after this PR. A WinGet failure is only a warning.publish.if: github.ref_name != 'beta'. The only conflicts are the 3publish.ymlhunks and thebuild.tshunk already incli-target-jobs. Beta skips this step..app.tar.gzon dev, as beta does (about a third of each macOS upload). It changes what ships to R2, so it needs its own PR.Verification
publish.ymlcan't run on this PR. On the first dev release dispatch:opencode-desktop-*upload: "there will be 5 files uploaded" on macOS, 2 on Windows, 3 on Linux; no "least common ancestor" line; size ~780/820 MB macOS, ~230 MB Windows, ~670/690 MB Linux; step time ~25–30 s on macOS and linux-arm64.publish: the download reports 6 artifacts in roughly 20–45 s; the desktopdry-run upload:andupload:lines list the same 20 names as 2.0.29/2.0.30; WinGet preparesAnomaly.OpenCode.Desktop.