fix(snapshot): add --ignore-errors to git add in stage to prevent transient missing file failures - #46140
Open
Samyak2406 wants to merge 1 commit into
Open
Conversation
…nsient missing file failures
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
@kitlangton @Hona Friendly ping for review when you have a moment. This fixes transient file deletion failures during Snapshot.stage() (issue #46138). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46138
Type of change
What does this PR do?
When external processes (such as Docker containers, database servers, or build tools) create and delete temporary files in the repository workspace while OpenCode's snapshot engine is running, a transient file can disappear between the candidate list discovery (
ls-files/diff-files) and the staging step (git add).Without
--ignore-errors,git addfails with exit code 128 (fatal: pathspec did not match any files), which causes snapshot staging to fail completely.Adding
--ignore-errorsto thegit addinvocation inSnapshot.stage()allows git to skip transient missing files during snapshot staging rather than failing the entire snapshot operation.How did you verify your code works?
git add --ignore-errors).Screenshots / recordings
N/A (backend snapshot service change, no UI changes)
Checklist