feat(app): pair servers from QR codes - #46098
Open
Hona wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Requested QR pairing for the V2 web and desktop clients. No linked issue.
Type of change
What does this PR do?
Adds QR pairing to Add Server using the existing
opencode2 pairpayload. Browser users can scan with a camera; web and desktop users can import a QR image. The dialog explains which command to run.URLparsing andipaddr.jsrange/CIDR APIs to prefer public addresses, then tailnet, LAN, link-local, and loopback. HTTPS breaks ties. Alternatives remain selectable; this is address preference, not a reachability probe.The QR format is unchanged and contains the reusable service password. Remote connections still require a reachable listener; browsers may block HTTP servers from an HTTPS page. This PR does not add TLS or change server binding.
How did you verify your code works?
bun typecheck; production web build.git diff --check.Full
typecheck:e2eis blocked by the existingHTMLElement | SVGElement.direrror ate2e/regression/new-session-workspace-pending.spec.ts:38, also present in the base commit. Physical camera hardware was not used.Screenshots / recordings
Before:
After:
Mobile:
RTL:
Checklist