fix(app): avoid zero message refresh limit - #42491
Open
fancive wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42267
Type of change
What does this PR do?
An empty initial message page records a cached message count of zero. A later forced refresh reused that count as the request limit, causing the desktop client to send
limit=0; the server rejects that value before the newly sent message can be loaded.This change falls back to the initial message page size whenever the cached or requested limit is zero. Positive cached limits continue to preserve the existing window size.
How did you verify your code works?
bun test src/context/server-session.test.ts: 75 passedbun typecheckinpackages/appScreenshots / recordings
Not included. The fix changes the message-fetch request limit; the request sequence is covered directly by the regression test.
Checklist