fix(app): size update pill to label - #42328
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42232
Type of change
What does this PR do?
The titlebar update pill used a fixed 68px expanded width, leaving excess space around short translations such as Chinese and constraining longer labels.
Size the expanded pill from its label's intrinsic width while preserving the 20px collapsed circle, right-aligned icon, focus/hover animation, and a 192px maximum for unusually long translations.
How did you verify your code works?
bun run typecheckbun run test:unit(722 passed)bun run test:browser(41 passed)bun run buildScreenshots / recordings
Before, from the issue report:
After the fix, the focused Chinese pill measures 51px instead of the fixed 68px. English and French expand to 65.5px and 94.52px respectively, while every collapsed pill remains 20px.
Checklist