fix(cli): dispose all instances on command exit - #42177
Open
vladislav-miroshnikov wants to merge 1 commit into
Open
fix(cli): dispose all instances on command exit#42177vladislav-miroshnikov wants to merge 1 commit into
vladislav-miroshnikov wants to merge 1 commit into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41841
Type of change
What does this PR do?
opencode run --session <id> --dir <path>can load a second InstanceContext via server middleware when the session's original directory differs from--dir. The CLI's finally block was callingstore.dispose(ctx), which only disposes the primary instance — the middleware-loaded instance is left running with its IPC server alive, so the process never exits.Changed
store.dispose(ctx)tostore.disposeAll()with alogWarningon failure (matching the pattern inglobal-lifecycle.ts). This ensures all instances loaded during the command are cleaned up. The JSDoc comment is updated to reflect the new behavior.serveandwebcommands are unaffected — they useinstance: falseand return before reaching the finally block. The TUI has its own disposal path.How did you verify your code works?
Typecheck clean. Existing tests for
disposeAllsemantics ininstance.test.ts(dedup, re-arm) remain green. The source-string assertion ineffect-cmd-instance-als.test.tsstill passes.Screenshots / recordings
N/A
Checklist