feat(tui): add permission_prompt size options - #41978
Closed
AliAltivate wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28191
Type of change
What does this PR do?
Adds two optional
tui.jsonoptions to control the permission prompt panel:permission_prompt.max_height— max height of the panel when not fullscreen (defaults to15, the previous hardcoded value).permission_prompt.default_expanded— open the permission prompt in fullscreen by default (false).The height was previously hardcoded (
maxHeight: 15) inpackages/tui/src/routes/session/permission.tsx. When a large diff needs approval, 15 lines is often too small and users had to pressctrl+fevery time. Both options are optional and backward-compatible: behavior is unchanged unless the user opts in.Schema added in
packages/tui/src/config/index.tsxfollowing the existingprompt/cursorconfig patterns;default_expandedonly takes effect when the prompt supports fullscreen (the main permission stage).How did you verify your code works?
packages/tui/test/config.test.tsx(valid values pass,max_height: 0throws).bun test test/config.test.tsxinpackages/tui— 9 pass.bun typecheckfrompackages/tuiand the full rootbun typecheck— clean.Screenshots / recordings
N/A (behavior only; no new UI surface).
Checklist