fix(opencode): isolate workspace config state - #41945
Open
Nath-Vikky wants to merge 1 commit into
Open
Conversation
Nath-Vikky
marked this pull request as ready for review
August 12, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41916
Type of change
What does this PR do?
Nested values merged from the global config cache could retain shared references. A plugin config hook mutating one workspace could therefore leak MCP configuration into workspaces loaded later by the same process.
This returns a structured clone from
Config.getGlobal()before workspace merging. Plugin hooks can still mutate their workspace config, while the global cache and other workspaces remain isolated.A regression test covers two workspaces loaded in the same process.
How did you verify your code works?
bun test test/config/config.test.ts --timeout 30000— 97 passedbun x prettier --check src/config/config.ts test/config/config.test.tsgit diff --checkScreenshots / recordings
Not applicable.
Checklist