feat(tui): surface plugin failures - #41940
Open
kitlangton wants to merge 3 commits into
Open
Conversation
kitlangton
enabled auto-merge (squash)
August 12, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Surface failed MCP servers and TUI plugins directly from the new-session screen, with
/mcpsand/pluginsas direct paths to full diagnostics.Failed rows open one shared error-details view with scrolling and copy support. A failed hot reload that keeps the previous plugin version running remains toggleable, so diagnostics do not remove the user's ability to stop it.
Before / After
Before: plugin failures appeared only as transient toasts. MCP failures showed only a generic indicator, and narrow terminals could clip multiple failure hints. A failed hot reload could also leave the previous plugin running without a control to deactivate it.
After: persistent failure counts appear in the home footer, Enter opens the complete error,
Ccopies it, and command hints collapse before labels at narrow widths. Failed-but-active plugins preserve both error inspection and the normal toggle action.How
dialog-error-details.tsxprovides the shared scroll, copy, and back interaction used by MCP and plugin failures.plugin/context.tsxcarries the registration ID on failed states when a last-good plugin survives.system/plugins.tsxcombines runtime state with registrations, omits unsupported targets from actionable rows, and separates Enter-to-inspect from toggle.home/footer.tsxreports exact failure counts and progressively hides secondary hints at 64 and 80 columns.Scope
This changes TUI diagnostics only. It does not change plugin loading, retry, or MCP connection behavior.
Testing
bun typecheckinpackages/tuibun run test test/plugin-reload.test.ts test/plugin-hot-reload.test.tsx test/feature-plugins/home-footer.test.tsinpackages/tuid480f5c449: started with a failed MCP, broke a live plugin during hot reload, verified failure counts, retained toggle, plugin and MCP details, copy feedback, back navigation, and the 50-column footerDemo
OpenCode Drive with deterministic local failure fixtures. The previous plugin version remains active after the failed hot reload.
recording-489a5692-0fb6-48f8-8c86-ed6420f0778c.mp4
Flow