fix(opencode): reject ambiguous fuzzy edits - #41927
Open
nanami7777777 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41872
Type of change
What does this PR do?
The edit replacer now collects all spans found by a matching strategy before applying a change. If a fuzzy strategy matches multiple concrete spans and
replaceAllis false, it reports the existing multiple-match error instead of editing the first byte-unique candidate. WithreplaceAll, it applies the replacement across the matched spans.This keeps whitespace-normalized matches like
alpha betaandalpha\tbetafrom bypassing the ambiguity guard.How did you verify your code works?
bun test test/tool/edit.test.tsinpackages/opencodebun typecheckinpackages/opencodeScreenshots / recordings
N/A; this is not a UI change.
Checklist