fix(tui): surface clipboard write failures instead of false success - #41924
Open
aishangwuji wants to merge 1 commit into
Open
fix(tui): surface clipboard write failures instead of false success#41924aishangwuji wants to merge 1 commit into
aishangwuji wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41470
Type of change
What does this PR do?
The TUI shows a "Copied to clipboard" toast even when the clipboard write silently failed, leaving the system clipboard empty. On Linux (e.g. Ubuntu), copy-on-select fires on mouse-up, but when no clipboard tool (
wl-copy/xclip/xsel) is available or the write errors out,packages/tui/src/clipboard.tsswallowed the error with.catch(() => undefined)in both the native command andclipboardyfallback paths.write()therefore always resolved, and every caller (Selection.copy,DialogProvider.copySelection, message/session copy, etc.) showed the success toast regardless of the actual outcome.The fix removes the error swallowing so real failures propagate to the callers' existing
toast.errorhandlers. To make the write path unit-testable, the native/clipboardy logic was extracted into an injectablewriteWith(deps, text).How did you verify your code works?
packages/tui/test/clipboard.test.tscases assertingwriteWithrejects when the native command or theclipboardyfallback fails (these fail against the old code), plus coverage for the success path and osascript escaping.bun test test/clipboard.test.tsinpackages/tui: 8/8 pass.bun typecheckinpackages/tui: passes.Screenshots / recordings
Not a visual change; behavior of the failure toast only.
Checklist