chore(core): drop obsolete StreamSse hunk from effect patch - #41892
Merged
Conversation
The hunk pinned the SSE transport wrapper's OpenAPI identifier to
${identifier}Stream. Upstream accepted the underlying bug (effect-smol
issue #2496, filed from opencode PR #34171) and fixed it more generally
in effect-smol #2512 - Schema.fromJsonString now names its encoded
wrapper ${identifier}JsonString - shipped since 4.0.0-beta.93. The
vendored beta.101 already contains that fix, so the hunk's only
remaining effect was renaming the canonical wrapper components.
Adopt the upstream names: V2EventStream -> V2EventJsonString and
SessionLogItemStream -> SessionLogItemJsonString. No TypeScript code
references either name; the only committed occurrence is the codemode
OpenAPI fixture, renamed in step. The payload components (V2Event,
SessionLogItem) are unaffected.
Leaves the patch carrying only the Deferred cleanup guard, which is
pending upstream - the file deletes entirely at the next effect bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
StreamSsehunk frompatches/effect@4.0.0-beta.101.patch, leaving only the Deferred cleanup guard. Net: -57 lines of patch, two OpenAPI components renamed to their upstream-canonical names.Why the hunk is obsolete
The hunk dates to #34171 (June 27): at beta.83,
Schema.fromJsonString's encoded wrapper inherited the decoded schema's identifier, so the SSE transport wrapper stoleV2Event's OpenAPI component name and the real union got renamedV2Event1. The hunk worked around it by pinning the wrapper to${identifier}Stream.Upstream accepted this as their bug (effect-smol#2496, filed citing opencode) and fixed it more generally in effect-smol#2512 (merged July 1, shipped since beta.93):
fromJsonStringnow names its encoded wrapper${identifier}JsonStringat the transformation boundary. The vendored beta.101 already contains that fix — the hunk's only remaining effect was renaming the wrapper components away from what every other Effect user sees.Blast radius
V2EventStream→V2EventJsonString,SessionLogItemStream→SessionLogItemJsonStringin the served OpenAPI specV2Event,SessionLogItem) unaffected — their protection is upstream's fix, verified by upstream testsTesting
bun install --force: patch applies cleanly; Deferred guard present; SSE code pristine upstream/openapi.jsonservesV2EventJsonString/SessionLogItemJsonString, payload components intactpackages/codemode: 1089/1089 tests pass against the renamed fixture