test(core): narrow effect flock harness - #41837
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cuts the EffectFlock suite's measured median runtime from 6.45 seconds to 3.64 seconds, about 44%, by avoiding an unrelated Core Location import graph in every lock worker.
Before / After
Before: The EffectFlock test and worker used
AppNodeBuilder, whose eager import of Core Location services loaded the complete application graph into the parent process and each of 16 contention workers. EffectFlock itself only depends onGlobalandFSUtil.After: Both boundaries compile
EffectFlock.nodedirectly withLayerNode.compile. Dependency provisioning remains explicit and identical, without importing Location services.How
AppNodeBuilder.buildwithLayerNode.compileineffect-flock.test.ts.effect-flock-worker.ts, where repeated process startup makes the import graph especially expensive.Scope
This is a test-harness import-boundary change only. It does not reduce contention coverage or alter EffectFlock behavior. Reducing the 16-worker stress count is a separate coverage tradeoff and is intentionally excluded.
Testing
bun typecheckfrompackages/coregit diff --check