fix(tui): ioctl TIOCGWINSZ poll + self-SIGWINCH for reflow under proot/Termux - #41832
Open
Albertban wants to merge 10 commits into
Open
fix(tui): ioctl TIOCGWINSZ poll + self-SIGWINCH for reflow under proot/Termux#41832Albertban wants to merge 10 commits into
Albertban wants to merge 10 commits into
Conversation
….stdout In Termux + proot (and other stdio-proxy environments) SIGWINCH is never delivered to the Bun process, so process.stdout rows/columns stay frozen at the startup value and the renderer never reflows to keyboard/rotation changes. Poll TIOCGWINSZ directly through ioctl (bun:ffi) and push real size changes into the renderer via resize(), falling back to no polling when the ioctl shim cannot be loaded.
v2 (ioctl polling) did not reflow under Termux+proot: the process.stdout.isTTY
gate likely disabled polling when the TUI swaps process.stdout, and
renderer.resize() appears to be a no-op in this build. v3 drops the gate and
on an ioctl-detected size change takes both paths:
1) renderer.resize(cols, rows) (may be a no-op in some builds)
2) process.kill(self, SIGWINCH) (reliably wakes OpenTUI's SIGWINCH handler,
which re-reads the real terminal size and repaints - the path verified
to actually reflow under Termux+proot)
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Termux + proot (user-space syscall emulation) never forwards SIGWINCH to the
Bun process, and Bun's process.stdout.rows/columns stay frozen at the startup
value. The default TUI (rendered via packages/tui
createCliRenderer) thereforestays at the startup terminal size forever: raising the soft keyboard covers the
lower half, and rotating the device never reflows.
Fix
packages/tui/src/termux-resize-fix.ts: every 300ms it reads the realterminal size via
ioctl(TIOCGWINSZ)(Bun FFI against libc), and on change itboth calls
renderer.resize(cols, rows)and deliversSIGWINCHto itself(the handler path that reliably makes OpenTUI re-read the real size and
repaint). Gracefully no-ops when
bun:ffi/dlopen is unavailable.packages/tui/src/app.tsx: starts the poll right after the renderer iscreated, stops it on
destroy.Test
device rotation now reflow to the correct size within ~300ms.
regular resize path is untouched.