refactor(core): centralize session message rows - #41830
Open
kitlangton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Centralizes the persisted
SessionMessagerepresentation boundary inSessionMessageRowinstead of repeating{ id, type, data }assembly and splitting throughout session persistence.How
packages/core/src/session/message-row.tswith effectful decode, synchronous decode, and synchronous encode operations.session_pendingrow codecs and fork row copying separate because those operations do not encode or decode the canonical message-row representation.Scope
This is representation-only refactoring. It does not change the
session_messageschema, durable event behavior, pending input encoding, fork batching, or caller-specific error handling.Testing
bun run test test/session-message-row.test.ts test/session-projector.test.ts test/session-create.test.ts test/session-prompt.test.tsfrompackages/core: 86 passedbun typecheckfrompackages/coregit diff --check