fix(app): use dedicated file manager icon on Linux - #41791
Open
huaruoji wants to merge 1 commit into
Open
Conversation
Co-authored-by: vacmar01 <vacmar01@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #12615
Replaces #12616 (the previous attempt was auto-closed after 60 days without updates).
Type of change
What does this PR do?
On Linux the "file manager" button in the session header and the V2 side panel showed the macOS Finder icon. There was no Linux-specific icon registered, so the Linux branch fell back to
finder.This PR adds a
file-managericon (Heroicons folder) to the app icon set and uses it for the Linux branch in both render paths (utils/file-manager.tsfor the V1 header,open-in-app.tsxfor the V2 side panel). The logic is the same as #12616, adapted to the current codebase.How did you verify your code works?
bun run --cwd packages/ui typecheckpassesbun run --cwd packages/app typecheckpassesScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
Screenshot of the issue is in #12615 (the icon shown there is the exact behavior this PR fixes). The change is a single icon swap, so the before state is visible in the linked issue.
Checklist