feat(tui): render structured mentions inline - #41752
Open
MagnumGoYB wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41197
Type of change
What does this PR do?
The V2 TUI rendered user-message text plainly, then showed files and skills as separate badges; agent mentions were not rendered. This adds a shared renderer that verifies every persisted display-width range against the text before styling file, agent, and skill mentions inline. Invalid, overlapping, or partial-wide-character ranges remain as badges, while image attachments keep their preview.
How did you verify your code works?
bun run testinpackages/tui: 631 passed, 5 skipped.bun typecheckinpackages/tui.bun turbo typecheck --concurrency=3: 33 packages passed.git diff --check.Screenshots / recordings
Not included. This changes terminal text styling; focused tests cover valid mixed mentions, Unicode display widths, stale ranges, and overlap fallback.
Checklist