fix(tui): include attachment path in model context - #41455
Open
cakeni wants to merge 1 commit into
Open
Conversation
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41454
Type of change
What does this PR do?
Preserves a local attachment's
source.pathas a text part immediately before the binary image in model context. Providers that discard image filenames can therefore still expose the user-selected path to the agent. A focused regression test covers the V2 message conversion. Prepared with AI assistance and validated locally.How did you verify your code works?
bun test test/session/message-v2.test.ts --timeout 30000— 40 passbun test test/session/llm.test.ts --timeout 30000— 28 passbun typecheckbun run prettier --ignore-unknown --check packages/opencode/src/session/message-v2.ts packages/opencode/test/session/message-v2.test.tsbun run oxlint packages/opencode/src/session/message-v2.ts packages/opencode/test/session/message-v2.test.ts— 0 errors; pre-existing warnings onlygit diff --checkThe full dependency install reached the unrelated
tree-sitter-powershellpostinstall, which requires a Visual Studio C++ workload unavailable in this environment; the targeted tests and package typecheck above completed successfully.Screenshots / recordings
Not applicable; this changes model context only and has no visual UI change.
Checklist