fix(effect-drizzle): declare query type variance - #41004
Open
zcxGGmu wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Refs #40890
Type of change
What does this PR do?
Adds explicit TypeScript variance annotations to the safe generic parameters on the Effect Drizzle session/select-builder types that showed up in the compiler variance trace.
SQLiteEffectSessionnow declares covariance forTRunResultandTRelationswhile preserving invariance forTEffectHKT.SQLiteEffectSelectBuildernow declares covariance forTRunResultand invariance forTEffectHKT/TBuilderMode.I intentionally left
TSelectioninferred because explicit annotations for it break the existing select overload relationships during typecheck.How did you verify your code works?
cd packages/effect-drizzle-sqlite && bun run typecheckcd packages/effect-drizzle-sqlite && bun test --timeout 30000bunx oxlint packages/effect-drizzle-sqlite/src/sqlite-core/effect/select.ts packages/effect-drizzle-sqlite/src/sqlite-core/effect/session.tsgit diff --checkScreenshots / recordings
N/A; this is a type-level performance cleanup.
Checklist