fix(provider): forward agent temperature for config-defined custom models - #40973
Open
SeashoreShi wants to merge 1 commit into
Open
fix(provider): forward agent temperature for config-defined custom models#40973SeashoreShi wants to merge 1 commit into
SeashoreShi wants to merge 1 commit into
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config-defined custom models (e.g.
provider.<id>.modelsinopencode.json) currently default totemperature: false, so an agent-leveltemperaturesetting is silently dropped for these models. This makes custom openai-compatible/other providers behave inconsistently with built-in models.This PR defaults the temperature capability to enabled for config-defined custom models, unless the user explicitly sets
temperature: falsefor that model. The agent's temperature is then forwarded to the provider request as expected.Changes
packages/opencode/src/provider/provider.ts: defaultcapabilities.temperaturetotruefor config-defined custom models (explicitmodel.temperaturestill wins).packages/opencode/test/provider/provider.test.ts: assert config-defined custom models reporttemperature: trueby default.packages/opencode/test/session/llm.test.ts: assert the provider request body actually carries the agent temperature for a custom openai-compatible model.Notes
This replaces the previously auto-closed #34555 (opencode's automated PR cleanup closed it despite the fix being confirmed by a user on 1.18.4). The branch is rebased on the latest
devand conflicts are resolved.