feat(tui): expose prompt action commands - #40971
Open
mustfsb wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #40953
Type of change
What does this PR do?
Exposes stable prompt action commands to TUI plugins for form and permission prompts:
form.option.previousform.option.nextform.actionpermission.option.previouspermission.option.nextpermission.actionThe existing prompt components still own selection, validation, submission, and permission behavior. The change promotes the existing keyboard handlers to named keymap commands, so plugins can discover and dispatch them without duplicating prompt state or synthesizing key events.
form.actionfollows the active form state, including option selection, text/custom input, external actions, and review submission.permission.actionalso covers the permission rejection prompt.Existing keyboard bindings and user-visible behavior are unchanged.
How did you verify your code works?
From
packages/tui:bun test test/cli/tui/prompt-plugin-commands.test.tsx— 20 passed, 0 failedbun typecheck— passedbun test— 614 passed, 5 skipped, 0 failedgit diff --check— passedThe regression tests verify command discovery, dispatch behavior, state transitions, keyboard behavior, rejection handling, and cleanup after prompts are unmounted.
Screenshots / recordings
Not applicable — this does not change the visible TUI. It exposes existing prompt actions through the plugin-facing keymap command API.
Checklist