fix(llm): treat empty tool call identity in stream deltas as absent - #40969
Closed
Curzibn wants to merge 1 commit into
Closed
fix(llm): treat empty tool call identity in stream deltas as absent#40969Curzibn wants to merge 1 commit into
Curzibn wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Streaming tool calls through an OpenAI-compatible endpoint fails with
OpenAI Chat tool call delta is missing id or nameon providers that sendidas an empty string (instead of omitting it) on continuation deltas. Alibaba DashScope (*.maas.aliyuncs.com/compatible-mode/v1, also serving qwen3-max / deepseek models) does this. The session errors out mid-turn and the pending tool call is never resolved.Actual chunks captured from DashScope (
qwen3.8-max):The first delta carries the real identity. Continuation deltas carry
id: ""with nofunction.name. InToolStream.appendOrStart,delta.id ?? current?.idkeeps the empty string (it is not nullish), so the fallback to the accumulated tool never happens and the truthiness guard reports the identity as missing.Fix
Fall back on empty-string identity the same as on absent identity (
||instead of??). A genuinely missing identity on the first delta for an index still errors as before.Tests
Added a
ToolStreamregression test replicating the DashScope shape: identity on the first delta,id: ""on the continuation delta.bun testinpackages/llm: 299 pass, 0 fail.