feat(core): add workspace environment foundation - #40967
Open
kitlangton wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the workspace environment foundation as a pure addition. Nothing consumes this module yet.
The core thesis is that spawn is the driver contract:
Filesis derived from an EffectChildProcessSpawner, while drivers may provide native fast-path overrides that promise identical observable semantics.How
Driver,Files,FileInfo,DirEntry, and exactNotFound/WrongKind/Failederror vocabulary underpackages/core/src/environment/.packages/core/test/lib/. The suite is the executable parity mechanism for this driver and future local and Modal drivers.execDefaultsplusCrossSpawnSpawneron Linux.GNU-only defaults are intentional: these commands run inside sandbox images we control. The exec-default conformance leg is skipped on non-Linux development hosts and runs on Linux CI.
Scope
Testing
cd packages/core && bun typecheckcd packages/core && bun run test test/environment*.test.ts(8 memory tests passed; 8 GNU tests skipped on macOS)cd packages/core && bun run test(1,555 passed, 15 skipped; unrelated existing failures inmodels.test.ts, invalid-regex handling intool-search.test.ts, andconfig/plugin.test.ts)