fix(tui): style destructive dialog actions - #40950
Open
kitlangton wants to merge 3 commits into
Open
Conversation
kitlangton
enabled auto-merge (squash)
August 7, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Give destructive
DialogSelectfooter actions a distinct keyboard-focus state while preserving the ordinary idle presentation.Before / After
Before: Focused Delete and Disconnect actions used the same primary styling as benign actions such as Rename, New, and Refresh.
After: All actions look neutral at rest. Focused session Delete, stash Delete, project-copy Delete, and connected MCP Disconnect use destructive action colors; benign actions keep primary focus colors.
How
primary | destructivevariant to sharedDialogSelectactions.Scope
This PR changes focused action styling only. It does not change confirmation, default selection, deletion, or disconnect behavior. Safe-default confirmation remains tracked in #36302.
Testing
bun typecheckfrompackages/tuibun run test test/cli/tui/dialog-select.test.tsx test/cli/cmd/tui/integration-options.test.tsgit diff --checkDemo
The comparison moves from neutral idle state to destructive Delete focus, then ordinary Rename focus.
destructive-comparison.mp4