fix(tui): clarify working copy actions - #40935
Open
kitlangton wants to merge 1 commit into
Open
Conversation
Contributor
Author
DemoBefore: The move confirmation uses labels-before.mp4After: The same keyboard flow uses labels-after.mp4 |
kitlangton
enabled auto-merge (squash)
August 6, 2026 23:25
kitlangton
force-pushed
the
confirm-action-labels
branch
from
August 6, 2026 23:58
dd703d0 to
85f03b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace ambiguous
no/yesworking-copy confirmation labels with actions that describe the result.Before / After
Before: Move and forced-delete confirmations displayed
no/yes, requiring users to infer what each choice would do.After: Move uses
cancel/move; forced deletion usescancel/delete.How
DialogWorkspaceFileChanges.DialogMoveSession.Scope
No confirmation behavior or default selection changes.
Testing
bun typecheckfrompackages/tuibun run test test/cli/tui/dialog-select.test.tsxgit diff --check