feat(tui): add pairing password toggle - #40934
Open
kitlangton wants to merge 1 commit into
Open
Conversation
Contributor
Author
DemoThe recording uses the fixed fixture credential Before: There is no visible password action, and pressing Space has no effect. pair-before.mp4After: The visible Space action reveals the fixture password and changes to pair-after.mp4 |
kitlangton
enabled auto-merge (squash)
August 6, 2026 23:25
kitlangton
force-pushed
the
pair-password-reveal
branch
from
August 6, 2026 23:58
da15694 to
536b99b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make pairing-password visibility discoverable and keyboard accessible.
Before / After
Before: The masked password could only be revealed by clicking the password text, with no visible affordance.
After: The dialog shows a configurable
space show password/space hide passwordaction that works from the keyboard or mouse.How
dialog.pair.toggle_passwordcommand.spacein the V2 TUI keybind definitions.Scope
The password remains masked by default. Pairing credentials and transport behavior are unchanged.
Testing
bun typecheckfrompackages/tuibun run test test/keybind.test.ts test/keymap.test.tsxgit diff --check