test(core): release shell test locations#35271
Open
kitlangton wants to merge 1 commit into
Open
Conversation
1aa95fa to
e02bc3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the aggregate
tool-shell.test.tshang by keeping each test's registry use inside one borrowed Location layer and invalidating that Location when the test body exits.The production Location cache intentionally retains services for 60 minutes. The test previously let every temporary Location retain its full watcher/process service graph, eventually stalling acquisition of another Location layer.
Effect.ensuringnow releases the test Location on success, failure, or interruption.Verification
v2: the full file stalled after several individually passing casesbun test --timeout 5000 test/tool-shell.test.tspassed three consecutive aggregate runs (39/39 cases)bun typecheckinpackages/core