feat(console): enforce 10mb request body limit on zen api#35237
Open
StarpTech wants to merge 2 commits into
Open
feat(console): enforce 10mb request body limit on zen api#35237StarpTech wants to merge 2 commits into
StarpTech wants to merge 2 commits into
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caps zen API request bodies at 10MB so callers cannot exhaust console resources with arbitrarily large context payloads.
Summary
readJsonBodythat rejects on declared content-length before reading, then counts bytes while consuming the stream since chunked requests can omit or understate the header/zen/v1/*and/zen/go/*routes across all billing sourcesBodyLimitError