fix(app): open project deep links in new layout#35223
Open
anduimagui wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35225
Type of change
What does this PR do?
Desktop
opencode://open-project?directory=...andopencode://new-session?directory=...links reached Electron, but the redesigned app layout did not consume them because the deep-link listener lived inside the legacy layout. In dev, where the redesigned layout is enabled by default, links could be logged by the main process without showing the requested project or opening the new-session composer.This adds a small shared
useDeepLinkListenerhook for the common drain/subscribe plumbing, keeps URL parsing inlayout/deep-links.ts, and lets each layout keep its own behavior. The legacy layout still opens/navigates to project sessions; the redesigned layout now opens and selects projects on the home view, handles optionalopen-projectsession links, and creates draft tabs fornew-sessionlinks.How did you verify your code works?
bun typecheckfrompackages/appbun test --preload ./happydom.ts ./src/pages/layout/helpers.test.tsfrompackages/appbun turbo typecheckopen 'opencode://open-project?directory=%2FUsers%2Fandrewmagu%2Fsrc%2Fpible'; confirmed the renderer main view showedpiblevia Electron CDPopen 'opencode://new-session?directory=%2FUsers%2Fandrewmagu%2Fsrc%2Fpible'; confirmed the renderer showed the new-session composer scoped topiblevia Electron CDPScreenshots / recordings
Not included. Verified the UI behavior live in the desktop dev app.
Checklist