fix(core): ensure parent directory exists in writeIfUnchanged#33096
Open
Robin1987China wants to merge 1 commit into
Open
fix(core): ensure parent directory exists in writeIfUnchanged#33096Robin1987China wants to merge 1 commit into
Robin1987China wants to merge 1 commit into
Conversation
writeIfUnchanged wrote without ensuring the parent directory exists, unlike create which catches NotFound and calls ensureDir before retry. If the parent dir is deleted between read and write, the write failed with an unhandled ENOENT. Now matches create's catch+ensureDir+retry pattern. Closes anomalyco#33075
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33075
Type of change
What does this PR do?
writeIfUnchangedinpackages/core/src/file-mutation.tswrote without ensuring the parent directory exists, unlikecreatewhich catchesNotFoundand callsfs.ensureDir(dirname(...))before retrying. If the parent directory was deleted between the read and write steps (TOCTOU), the write failed with an unhandled ENOENT.This PR extracts the write expression into a
writeconst and adds the sameEffect.catchReason("PlatformError", "NotFound", ...)+ensureDir+ retry pattern already used bycreate(line 130-133).How did you verify your code works?
bun turbo typecheck: all 29 packages passcreate— only fires onNotFound, normal path unaffectedChecklist