fix(experimental llm pkg): forward topK to Converse via additionalModelRequestFields#33030
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33003
Type of change
What does this PR do?
The Bedrock Converse path silently drops the
topKgeneration option.fromRequestinpackages/llm/src/protocols/bedrock-converse.tsbuildsinferenceConfigfrom only maxTokens/temperature/topP/stopSequences, and never readsgeneration.topK.The sibling Anthropic path already handles it (
anthropic-messages.ts:top_k: generation?.topK), so the same model setting behaves differently depending on which protocol is used. The fix routestopKthroughadditionalModelRequestFieldsastop_k. That is exactly where the AWS Converse API expects model-specific params that aren't part of the baseInferenceConfiguration— the Converse API reference shows{"additionalModelRequestFields": {"top_k": 200}}for Anthropic models. The Converse body schema in this file already declaresadditionalModelRequestFields, so nothing new is introduced — this fills a gap in the existing mapping.How did you verify your code works?
From
packages/llm:test/provider/bedrock-converse.test.ts: one assertingtopKlands inadditionalModelRequestFields: { top_k }, one asserting the field is omitted whentopKis unset. Reverting the one-line fix makes the first test fail (Expected { top_k: 40 }, received none), confirming the test catches the bug.bun test test/provider/bedrock-converse.test.ts→ 28 pass;bun typecheck,oxlint,prettier --checkall clean.Screenshots / recordings
Not a UI change.
Checklist
AI-assisted (Claude Code); changes, rationale, and tests reviewed by a human before submission.