fix(app): insert newline on Enter for mobile prompt input#32830
Open
gjuoun wants to merge 1 commit into
Open
Conversation
Detect touch-only devices via createMediaQuery("(hover: none)") and
route Enter (no modifiers) to the existing newline-insertion path so
mobile users — who have no Shift key on their virtual keyboard — can
add newlines without accidentally submitting. The send button remains
the sole submit path on touch devices; desktop behavior is unchanged.
Fixes anomalyco#20965
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20965
Type of change
What does this PR do?
Mobile virtual keyboards have no Shift key, so the existing
Shift+Enter → newline/Enter → submitcontract leaves mobile users with no way to insert newlines — every Enter press submits.This adds one branch in
handleKeyDown(packages/app/src/components/prompt-input.tsx) that detects touch-only devices viacreateMediaQuery("(hover: none)")— the same primitive already used insidebar-workspace.tsx— and routesEnterto the existing newline-insertion path on those devices. The send button (IconButton type="submit") remains the submit path on touch.Desktop behavior is unchanged:
Enterstill submits,Shift+Enterstill inserts a newline. The new branch sits AFTER the popover-navigation block so popover-Enter (e.g.,@-mention selection) still works on mobile.Prior attempt: #9362 (closed for inactivity, confirmed working by users) used UA sniffing; this PR uses the codebase's existing media-query pattern instead.
How did you verify your code works?
bun lint— cleanbun typecheckinpackages/app/— cleanbun testinpackages/app/— no regressionsScreenshots / recordings
Happy to record a before/after demo on request.
Checklist