fix(opencode): normalize MCP structured arguments#32812
Open
davilima6 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28472
Related Next.js DevTools MCP reproduction: #28472 (comment)
Type of change
What does this PR do?
MCP tools can receive JSON-shaped object arguments as strings. When the advertised MCP schema says a field should be an object or array, this PR parses JSON strings back into structured values before calling
client.callTool.It also handles empty strings for structured fields by converting them to
{}or[]. Invalid JSON strings are left unchanged so the MCP server can still return its own validation error.How did you verify your code works?
bun test test/mcp/catalog.test.tsfrompackages/opencodebun typecheckfrompackages/opencodebun run lintfrom repo root completed with 0 errors, existing warnings onlybun turbo typechecksuccessfullyScreenshots / recordings
Not a UI change.
Checklist