feat(mcp): publish resource list change events#32478
Open
Nomadcxx wants to merge 1 commit into
Open
Conversation
1 task
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found two potentially related PRs that address similar MCP resource functionality:
These PRs appear to be addressing the same feature area around MCP resource notifications. PR #31396 in particular seems most likely to be a duplicate since it covers the exact same "resource list change notifications" functionality that PR #32478 is implementing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Refs #28567
Type of change
What does this PR do?
Adds the first small slice of MCP resource notification support.
When an MCP server advertises
resources, opencode now registers a handler fornotifications/resources/list_changedand publishes a typedmcp.resources.changedevent with the server name.This gives clients/UI/plugin code a clean signal to refresh resource lists without polling or treating MCP-originated updates as user messages.
I intentionally kept this to list-change notifications only.
notifications/resources/updatedshould come in a follow-up with explicit subscribe/unsubscribe behaviour, otherwise opencode would be handling resource updates it never chose to watch.How did you verify your code works?
Added an MCP lifecycle test for a resource-only MCP server. The test triggers the mocked
ResourceListChangedNotificationSchemahandler and verifies amcp.resources.changedevent is emitted.Ran:
Checklist