fix(session-header): call isDesktopV2() memo in Show when predicate#31875
Open
EdwardYuen wants to merge 1 commit into
Open
fix(session-header): call isDesktopV2() memo in Show when predicate#31875EdwardYuen wants to merge 1 commit into
EdwardYuen wants to merge 1 commit into
Conversation
A createMemo accessor reference (always truthy) was passed to Solid's
<Show when={...}> instead of calling it, so the V1 fallback icons
(open-in-editor, terminal toggle, file tree toggle) never rendered.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A createMemo accessor reference (always truthy) was passed to Solid's instead of calling it, so the V1 fallback icons (open-in-editor, terminal toggle, file tree toggle) never rendered.
Issue for this PR
Closes #31878
Type of change
What does this PR do?
The file tree and terminal toggle buttons were completely missing from the titlebar.
This happened because
isDesktopV2is a SolidJS memo accessor, but it was being passed into<Show when={isDesktopV2}>as a raw function reference instead of being called asisDesktopV2(). Since JavaScript functions are always truthy, the fallback V1 layout icons never had a chance to render. Calling the function fixes the reactive rendering logic.How did you verify your code works?
bun run --cwd packages/desktop devlocally and flipped the "New layout and designs" toggles back and forth in Settings. The titlebar buttons now show up in the V1 old design.Screenshots / recordings
Checklist