fix(ui): reduce settings panel backdrop opacity, add dialog animations, fix clipped icons#31864
Open
cola0908 wants to merge 1 commit into
Open
fix(ui): reduce settings panel backdrop opacity, add dialog animations, fix clipped icons#31864cola0908 wants to merge 1 commit into
cola0908 wants to merge 1 commit into
Conversation
…s, fix clipped icons - Reduce scrim opacity from 40%/30% to 20% for lighter backdrop dimming - Add fade-in/fade-out animations for dialog overlay and content (150ms show, 100ms hide) - Increase settings sidebar trigger height from 28px to 32px to prevent icon clipping - Remove overflow: clip from tabs-v2 container to fix content clipping - Increase V2 titlebar height from 36px to 40px to match Electron native titlebar overlay Closes anomalyco#31863
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31863
Type of change
What does this PR do?
The V2 settings panel has 4 UI issues:
Backdrop too dark — The scrim overlay dims the background at 40% opacity (light) / 30% (dark), which feels heavy. Reduced to 20% in both modes.
No open/close animation — The dialog appears and disappears instantly. Added 150ms ease-out fade-in and 100ms ease-in fade-out for both the overlay (opacity) and content (scale 0.97↔1 + opacity).
Sidebar icons clipped — The settings sidebar trigger height was 28px, too tight for the 20px icons. Increased to 32px and removed
overflow: clipon the tabs container.Titlebar icons clipped — V2 titlebar was 36px but Electron's native titlebar overlay expects 40px, causing the icon boxes to be cut off at the edges.
How did you verify your code works?
All changes are CSS-only (plus one
data-closingattribute in the dialog context). Verified by reviewing the computed styles and animation keyframes. The changes are minimal and targeted — no logic changes that could break runtime behavior.Screenshots / recordings
Before: heavy dark overlay, instant dialog appear/disappear, clipped icons in sidebar and titlebar.
After: lighter 20% overlay, smooth fade animations, icons fully visible.
Checklist