fix: align @npmcli/agent patch version with resolved lockfile#31362
Open
HrushiYadav wants to merge 1 commit into
Open
fix: align @npmcli/agent patch version with resolved lockfile#31362HrushiYadav wants to merge 1 commit into
HrushiYadav wants to merge 1 commit into
Conversation
- patch was pinned to @4.0.0 but bun.lock resolves @4.0.2 - proxy.url .toString() fix was silently skipped, breaking plugin installs behind HTTP_PROXY/HTTPS_PROXY
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31319
Type of change
What does this PR do?
patchedDependenciesin package.json targets@npmcli/agent@4.0.0but bun.lock resolves@4.0.2. Since the version doesn't match, the patch that calls.toString()onproxy.urlis never applied. This causesfetch() proxy.url must be a non-empty stringerrors and hangs whenHTTP_PROXY/HTTPS_PROXYare set.Fix: bump the patch target from 4.0.0 to 4.0.2 and rename the patch file. The patched line in
lib/agents.jsis identical between both versions.How did you verify your code works?
lib/agents.jsfrom both@npmcli/agent@4.0.0and@4.0.2via npm registry tarballs — theget proxy()getter is identical, patch applies cleanlybun.lockresolves@4.0.2whilepatchedDependenciestargeted@4.0.0Screenshots / recordings
N/A — not a UI change.
Checklist