fix(shell): set utf8 output encoding for powershell#31346
Open
qinant wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Why it's likely related: This PR (#31297) also addresses PowerShell UTF-8 encoding issues, which is the same core problem being fixed in the current PR (#31346). Both PRs appear to target the same issue (#31345) and apply UTF-8 output encoding configuration to PowerShell shell execution. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23636
Closes #31187
Closes #30205
Type of change
What does this PR do?
PowerShell on Windows can emit shell output using the active console code page, while opencode decodes captured output as UTF-8. This makes Chinese and other non-ASCII output render as mojibake.
This PR wraps PowerShell commands with UTF-8 output encoding setup before running the user command. The wrapper is used by both direct shell execution and the shell tool path.
How did you verify your code works?
If renders correctly in the shell output prove it works. And i have checked it locally.
Screenshots / recordings
before fix this bug, there are mojibake in output:
After fix there are no mojibake in output:
Checklist