Skip to content

fix(core): reject binary files before reading#31029

Closed
opencode-agent[bot] wants to merge 1 commit into
fix/v2-read-imagesfrom
fix/v2-binary-detection
Closed

fix(core): reject binary files before reading#31029
opencode-agent[bot] wants to merge 1 commit into
fix/v2-read-imagesfrom
fix/v2-binary-detection

Conversation

@opencode-agent
Copy link
Copy Markdown
Contributor

@opencode-agent opencode-agent Bot commented Jun 5, 2026

Summary

  • port V1 extension and sampled-byte binary classification into Core V2
  • reject unsupported binary files before direct reads or text pagination
  • avoid serializing base64 binary data into model-visible tool output
  • preserve supported image handling from the preceding PR

Test plan

  • bun test test/tool-read.test.ts test/tool-glob.test.ts test/tool-grep.test.ts test/location-filesystem.test.ts from packages/core
  • bun typecheck from packages/core
  • repository pre-push bun turbo typecheck

Stack

Depends on the V2 image-read PR.

@kitlangton
Copy link
Copy Markdown
Contributor

Superseded by #31038, which rebuilds the binary-safety and media behavior together on current , including durable replay, provider lowering, and single-descriptor filesystem validation.

@kitlangton kitlangton closed this Jun 5, 2026
@kitlangton
Copy link
Copy Markdown
Contributor

Correction: #31038 rebuilds the unified fix on current dev, including durable replay, provider lowering, and single-descriptor filesystem validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant