fix(ui): avoid blocking on large file diffs#30962
Open
xpluspro wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30906
Type of change
What does this PR do?
Large whole-file patches were reconstructed and passed through the synchronous Myers diff algorithm in the renderer, which could freeze the UI.
This change keeps patches above the existing 500 changed-line threshold or 500,000 characters on the partial patch parser path. Smaller patches still render as complete diffs.
How did you verify your code works?
Ran:
cd packages/ui && bun test src/components/session-diff.test.tsAll 12 tests passed. Added regression tests for large patches and patches with many changed lines.
Screenshots / recordings
Not applicable. This changes diff processing behavior without changing the UI.
Checklist