fix: add --no-orphans to compiled binary execArgv#30875
Open
jwcrystal wants to merge 1 commit into
Open
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Enable Bun's --no-orphans flag so MCP stdio server child processes cannot outlive the opencode parent process on Linux and macOS. Bun's no-orphans mode uses PR_SET_PDEATHSIG (Linux) and kqueue EVFILT_PROC (macOS) to ensure all descendant processes are killed when the parent exits, even on SIGKILL or crash.
7f322f1 to
f9c01fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30123
For context: existing issues #30073, #30123, and #26714 all discuss the same MCP orphan problem. This PR takes the simplest approach — enabling Bun's built-in
--no-orphansmode in the compiled binary — rather than adding aprocess.on('exit')handler or modifying MCP lifecycle logic.Type of change
What does this PR do?
Adds
--no-orphansto the compiled binary'sexecArgvin the build script. When opencode exits, Bun now automatically kills all descendant processes (including MCP stdio servers spawned viaStdioClientTransport).Before this change, MCP child processes became orphans reparented to init/launchd on abnormal exit (SIGKILL/crash) or the
process.exit()fallback. Bun's--no-orphanshandles both clean and unclean exits (Linuxprctl/ macOS kqueue descendant reaper).How did you verify your code works?
The change is a single flag addition to the Bun build config (
execArgv). The flag is documented and maintained by Bun — verified its behavior matches the implementation described in Bun'sParentDeathWatchdog(Linuxprctl, macOS kqueue, clean-exit tree walk with SIGSTOP+verify SIGKILL). No runtime test was added because the behavior depends on Bun's runtime internals, not opencode logic.Screenshots / recordings
N/A
Checklist