fix(app): keep titlebar controls visible by making session tabs scrollable#30817
Open
Mohamed998788 wants to merge 5 commits into
Open
fix(app): keep titlebar controls visible by making session tabs scrollable#30817Mohamed998788 wants to merge 5 commits into
Mohamed998788 wants to merge 5 commits into
Conversation
Co-authored-by: Mohamed998788 <194706782+Mohamed998788@users.noreply.github.com>
…342089943340 Project Exploration and Analysis
… visible Co-Authored-By: Mohamed Youssef <Mohamed.youssef142011@gmail.com>
…bs-scroll fix(app): keep titlebar controls visible by making session tabs scrollable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the V2 titlebar, when enough conversation tabs are open to fill the top bar, the tab row pushed the right-side controls (new-session +, Status, Toggle review) completely off-screen, and there was no way to reach tabs that overflowed.
Root cause: the V2 titlebar layout did not constrain the tab row to the header width.
Changes (all in packages/app/src/components/titlebar.tsx):
Net effect: tabs scroll horizontally and the right-side controls always stay visible.
How did you verify your code works?
Ran locally with the backend + app dev servers and opened ~12 sessions so the tab bar overflowed.
Screenshots / recordings
Tab bar with many sessions open after the fix — tabs scroll horizontally and the + / right-side controls remain visible at the right edge.