fix(session): respect directory filter with workspaces#30804
Open
rexdotsh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30801
Type of change
What does this PR do?
Fixes directory-scoped session lists when experimental workspaces are enabled.
Before this change,
Session.list({ directory })ignoreddirectoryin that mode unless callers also passed apath. The web sidebar could then receive project-wide results, filter them client-side by exact directory, and render onlyNew session+Load moreeven though sessions existed.This makes
directoryapply wheneverscope: "project"was not explicitly requested, and adds regression coverage for two sibling directories in the same git project.How did you verify your code works?
cd packages/opencode && bun test test/server/session-list.test.tscd packages/opencode && bun typecheckScreenshots / recordings
Before
chrome_t6ztZ0DWtg.mp4
After
Checklist