fix(tui): suppress diff viewer keybindings when dialog is open#30787
Open
lawRathod wants to merge 1 commit into
Open
fix(tui): suppress diff viewer keybindings when dialog is open#30787lawRathod wants to merge 1 commit into
lawRathod wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the diff viewer TUI plugin to register its key bindings under the OpenCode base keymap mode.
Changes:
- Import
OPENCODE_BASE_MODEfrom@tui/keymap. - Pass
mode: OPENCODE_BASE_MODEinto theuseBindingsconfiguration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
We checked all other |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30754
Type of change
What does this PR do?
Opening Commands (command palette) while the Diff Viewer is open steals letter keys — q, s, d, p, E trigger diff actions instead of typing into the search input.
The cause: the diff viewer's
useBindings()had nomodeconstraint, so its keybindings stayed active even after a dialog pushed"modal"onto the mode stack. The fix addsmode: OPENCODE_BASE_MODE, matching the pattern already used by session, permission, and question views.Change: 2 lines in
diff-viewer.tsx— one import, onemodefield.How did you verify your code works?
useBindings()calls in the TUI have the same gapScreenshots / recordings
BUG
https://github.com/user-attachments/assets/33830aed-9604-4c08-b3d5-a20bd83d6175
FIX
https://github.com/user-attachments/assets/06f159cc-a06c-470e-b3d6-e6cdfe6388e6
Checklist